feat(manager): add api versioning to manager#72
Open
Rodriguespn wants to merge 3 commits intosinglestore-labs:mainfrom
Open
feat(manager): add api versioning to manager#72Rodriguespn wants to merge 3 commits intosinglestore-labs:mainfrom
Rodriguespn wants to merge 3 commits intosinglestore-labs:mainfrom
Conversation
Rodriguespn
force-pushed
the
feature/v2-endpoints
branch
from
e419a73 to
28debbf
Compare
kesmit13
reviewed
Jul 15, 2025
| class Manager(object): | ||
| """SingleStoreDB manager base class.""" | ||
|
|
||
| #: Management API version if none is specified. |
Collaborator
There was a problem hiding this comment.
I think we need to keep this variable in there and account for it in the constructor. There are subclasses of this class that use a different version than v1 (actually just ClusterManager right now). But we still need this behavior.
Contributor
Author
There was a problem hiding this comment.
Thanks for the heads up. Brought the default_version attr back and now, on the manager constructor, self.version = version or self.default_version. This means that unless the user explicitly specifies the api version to use, this will fallback to the default_version (global from config.py or "v1")
Rodriguespn
force-pushed
the
feature/v2-endpoints
branch
from
28debbf to
af1421d
Compare
kesmit13
reviewed
Jul 15, 2025
kesmit13
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some management api endpoints that have a different api version (v2). To handle these cases, we created a new generic attribute of the Manager class that copies the manager and changes the api version